Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained django debug panel in favour of django debug toolbar #13159

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Remove unmaintained django debug panel in favour of django debug toolbar #13159

merged 1 commit into from
Mar 26, 2025

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Mar 6, 2025

Summary

  • Django debug panel is no longer maintained, and alas, no longer seems to work
  • There do seem to be plans to have a proper public API for the debug toolbar data which may allow something similar in the future
  • For now, revert to just using debug toolbar
  • Simplifies our browsable API interface so that the debug toolbar info is meaningful and about the request made, not extraneous data

Reviewer guidance

Follow the new guidance - does it work?

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Mar 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0b1.dev0_git.128.g467ca353.pex
Windows Installer (EXE) kolibri-0.18.0b1.dev0+git.128.g467ca353-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0b1.dev0+git.128.g467ca353-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0b1.dev0+git.128.g467ca353.dmg
Android Package (APK) kolibri-0.18.0b1.dev0+git.128.g467ca353-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0b1.dev0+git.128.g467ca353.zip
TAR file kolibri-0.18.0b1.dev0+git.128.g467ca353.tar.gz
WHL file kolibri-0.18.0b1.dev0+git.128.g467ca353-py2.py3-none-any.whl

@nucleogenesis nucleogenesis self-assigned this Mar 24, 2025
nucleogenesis
nucleogenesis approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out locally and all works as expected. Was pretty cool being able to follow and API request and see the SQL it caused to be run. This PR is a nice reminder that the tool is there in case I might need it :)

@rtibbles rtibbles force-pushed the django_debug_toolbar branch from 7133c43 to 3613b9d Compare March 26, 2025 21:00
@rtibbles rtibbles merged commit b9044f6 into learningequality:develop Mar 26, 2025
51 checks passed
@rtibbles rtibbles deleted the django_debug_toolbar branch March 26, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

Assignees

@nucleogenesis nucleogenesis

Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @nucleogenesis